Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key parse bug for components #1338

Merged
merged 1 commit into from
Jun 21, 2020
Merged

Fix key parse bug for components #1338

merged 1 commit into from
Jun 21, 2020

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Jun 21, 2020

Description

It looks like components don't get their key or node_ref assigned in the virtual dom if they have no other properties.

Fixes #1301

Checklist:

  • I have run ./ci/run_stable_checks.sh
  • I have reviewed my own code
  • I have added tests – if this is a bug fix, these tests will fail if the bug is present (to stop it from cropping up again). If this is a feature, my tests prove that the feature works.

@jstarry jstarry merged commit f56020f into yewstack:master Jun 21, 2020
@jstarry jstarry deleted the fix-keyed-comp branch June 21, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Key not parsed for components
1 participant
@jstarry